lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 18 Oct 2014 08:16:39 -0700 From: Christoph Hellwig <hch@...radead.org> To: "Martin K. Petersen" <martin.petersen@...cle.com> Cc: michaelc@...wisc.edu, linux-scsi@...r.kernel.org, target-devel@...r.kernel.org, ceph-devel@...r.kernel.org, axboe@...nel.dk, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/5] block: add function to issue compare and write On Fri, Oct 17, 2014 at 07:38:37PM -0400, Martin K. Petersen wrote: > The problem with this is that, as it stands, a bio has no type. And it > would suck if we couldn't keep bio rw and request flags in sync. > > I wonder if it would make more sense to move the remaining rq types to > cmd_flags after I'm done with the 64-bit conversion? I'd prefer adding a cmd_type to the bio as well and avoid the 64-bit flag conversion. While we'll probably grow more types of I/Os (e.g. copy offload) I hope we can actually reduce the number of real flags, and it's easier to read for sure if we can switch on the command type in the driver. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists