lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 17 Oct 2014 19:38:37 -0400 From: "Martin K. Petersen" <martin.petersen@...cle.com> To: Christoph Hellwig <hch@...radead.org> Cc: michaelc@...wisc.edu, linux-scsi@...r.kernel.org, target-devel@...r.kernel.org, ceph-devel@...r.kernel.org, axboe@...nel.dk, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/5] block: add function to issue compare and write >>>>> "Christoph" == Christoph Hellwig <hch@...radead.org> writes: Christoph> We already have req->cmd_type which actually is a fairly good Christoph> description of what we get except for REQ_TYPE_FS, which is a Christoph> horrible overload using req->cmd_flags. Christoph> Given that you're just one of many currently ongoing patches Christoph> to add more flags here I think you need to byte the bullet Christoph> and fix this up by replacing REQ_TYPE_FS with: Christoph> REQ_TYPE_WRITE REQ_TYPE_READ REQ_TYPE_FLUSH REQ_TYPE_DISCARD Christoph> REQ_TYPE_WRITE_SAME REQ_TYPE_CMP_AND_WRITE The problem with this is that, as it stands, a bio has no type. And it would suck if we couldn't keep bio rw and request flags in sync. I wonder if it would make more sense to move the remaining rq types to cmd_flags after I'm done with the 64-bit conversion? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists