linux-kernel - Re: [PATCH] kernel/sysctl: Resolve missing-field-initializers warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a94szydt.fsf@x220.int.ebiederm.org>
Date:	Sat, 18 Oct 2014 17:39:10 -0700
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	akpm@...ux-foundation.org, mingo@...nel.org,
	Mark Rustad <mark.d.rustad@...el.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel/sysctl: Resolve missing-field-initializers warnings

Jeff Kirsher <jeffrey.t.kirsher@...el.com> writes:

> From: Mark Rustad <mark.d.rustad@...el.com>
>
> Resolve missing-field-initializers warnings in W=2 builds by
> using designated initialization.

ick.  No.

That gcc warning makes no sense.  In this case heeding it makes the code
significantly uglier and significantly more confusing.

Eric


> Signed-off-by: Mark Rustad <mark.d.rustad@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> ---
>  kernel/sysctl.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/kernel/sysctl.c b/kernel/sysctl.c
> index 4aada6d..5623845 100644
> --- a/kernel/sysctl.c
> +++ b/kernel/sysctl.c
> @@ -257,7 +257,7 @@ static struct ctl_table sysctl_base_table[] = {
>  		.mode		= 0555,
>  		.child		= dev_table,
>  	},
> -	{ }
> +	{ .procname = NULL }
>  };
>  
>  #ifdef CONFIG_SCHED_DEBUG
> @@ -1103,7 +1103,7 @@ static struct ctl_table kern_table[] = {
>  		.proc_handler	= proc_dointvec,
>  	},
>  #endif
> -	{ }
> +	{ .procname = NULL }
>  };
>  
>  static struct ctl_table vm_table[] = {
> @@ -1485,12 +1485,12 @@ static struct ctl_table vm_table[] = {
>  		.mode		= 0644,
>  		.proc_handler	= proc_doulongvec_minmax,
>  	},
> -	{ }
> +	{ .procname = NULL }
>  };
>  
>  #if defined(CONFIG_BINFMT_MISC) || defined(CONFIG_BINFMT_MISC_MODULE)
>  static struct ctl_table binfmt_misc_table[] = {
> -	{ }
> +	{ .procname = NULL }
>  };
>  #endif
>  
> @@ -1658,7 +1658,7 @@ static struct ctl_table fs_table[] = {
>  		.proc_handler	= &pipe_proc_fn,
>  		.extra1		= &pipe_min_size,
>  	},
> -	{ }
> +	{ .procname = NULL }
>  };
>  
>  static struct ctl_table debug_table[] = {
> @@ -1682,11 +1682,11 @@ static struct ctl_table debug_table[] = {
>  		.extra2		= &one,
>  	},
>  #endif
> -	{ }
> +	{ .procname = NULL }
>  };
>  
>  static struct ctl_table dev_table[] = {
> -	{ }
> +	{ .procname = NULL }
>  };
>  
>  int __init sysctl_init(void)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/