linux-kernel - Re: [PATCH] kernel/sysctl: Resolve missing-field-initializers warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20141021120711.0ddb53adb4fdecf241826473@linux-foundation.org>
Date:	Tue, 21 Oct 2014 12:07:11 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	ebiederm@...ssion.com (Eric W. Biederman)
Cc:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>, mingo@...nel.org,
	Mark Rustad <mark.d.rustad@...el.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel/sysctl: Resolve missing-field-initializers
 warnings

On Sat, 18 Oct 2014 17:39:10 -0700 ebiederm@...ssion.com (Eric W. Biederman) wrote:

> Jeff Kirsher <jeffrey.t.kirsher@...el.com> writes:
> 
> > From: Mark Rustad <mark.d.rustad@...el.com>
> >
> > Resolve missing-field-initializers warnings in W=2 builds by
> > using designated initialization.
> 
> ick.  No.
> 
> That gcc warning makes no sense.  In this case heeding it makes the code
> significantly uglier and significantly more confusing.
> 

Yeah, it's not pretty.

> > --- a/kernel/sysctl.c
> > +++ b/kernel/sysctl.c
> > @@ -257,7 +257,7 @@ static struct ctl_table sysctl_base_table[] = {
> >  		.mode		= 0555,
> >  		.child		= dev_table,
> >  	},
> > -	{ }
> > +	{ .procname = NULL }
> >  };

We use { } to mean "all zero" in 12 squillion places.  Do they all warn
or is there something special about this site?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/