lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 20 Oct 2014 14:29:15 +0200
From:	Boris Brezillon <boris.brezillon@...e-electrons.com>
To:	Varka Bhadram <varkabhadram@...il.com>
Cc:	David Woodhouse <dwmw2@...radead.org>,
	Brian Norris <computersforpeace@...il.com>,
	linux-mtd@...ts.infradead.org, Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>, devicetree@...r.kernel.org,
	linux-sunxi@...glegroups.com, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	Yassin Jaffer <yassinjaffer@...il.com>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>
Subject: Re: [PATCH v6 1/2] mtd: nand: add sunxi NAND flash controller
 support

Hi Varka,

On Mon, 20 Oct 2014 17:31:51 +0530
Varka Bhadram <varkabhadram@...il.com> wrote:

> On 10/20/2014 05:15 PM, Boris Brezillon wrote:
> > Add support for the sunxi NAND Flash Controller (NFC).
> >
> (...)
> 
> > +
> > +static int sunxi_nfc_dev_ready(struct mtd_info *mtd)
> > +{
> > +	struct nand_chip *nand = mtd->priv;
> > +	struct sunxi_nand_chip *sunxi_nand = to_sunxi_nand(nand);
> > +	struct sunxi_nfc *nfc = to_sunxi_nfc(sunxi_nand->nand.controller);
> > +	struct sunxi_nand_rb *rb;
> > +	unsigned long timeo = (sunxi_nand->nand.state == FL_ERASING ? 400 : 20);
> > +	int ret;
> > +
> > +	if (sunxi_nand->selected < 0)
> > +		return 0;
> > +
> > +	rb = &sunxi_nand->sels[sunxi_nand->selected].rb;
> > +
> > +	switch (rb->type) {
> > +	case RB_NATIVE:
> > +		ret = !!(readl(nfc->regs + NFC_REG_ST) &
> > +			 (NFC_RB_STATE0 << rb->info.nativeid));
> > +		if (ret)
> > +			break;
> > +
> > +		sunxi_nfc_wait_int(nfc, NFC_RB_B2R, timeo);
> > +		ret = !!(readl(nfc->regs + NFC_REG_ST) &
> > +			 (NFC_RB_STATE0 << rb->info.nativeid));
> > +		break;
> > +	case RB_GPIO:
> > +		ret = gpio_get_value(rb->info.gpio);
> > +		break;
> > +	case RB_NONE:
> > +	default:
> > +		ret = 0;
> > +		pr_err("cannot check R/B NAND status!");
> 
> Missed terminating  new line...  :-)

I'll fix that.

> 
> > +		break;
> > +	}
> > +
> > +	return ret;
> > +}
> > +
> > +
> 
> (...)
> 
> > +static struct platform_driver sunxi_nfc_driver = {
> > +	.driver = {
> > +		.name = "sunxi_nand",
> > +		.owner = THIS_MODULE,
> 
> This field updated by module_platform_driver()..

Yep, I'll remove this line.

Thanks for your review.

Best Regards,

Boris


-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists