linux-kernel - Re: [PATCH 1/2] Thermal:Fix memory leak if occur goto unregister

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141020123338.GA3744@developer>
Date:	Mon, 20 Oct 2014 08:33:40 -0400
From:	Eduardo Valentin <edubezval@...il.com>
To:	Yao Dongdong <yaodongdong@...wei.com>
Cc:	Zhang Rui <rui.zhang@...el.com>, linux-pm@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] Thermal:Fix memory leak if occur goto unregister

Hello,

On Mon, Oct 20, 2014 at 04:27:36PM +0800, Yao Dongdong wrote:
> Signed-off-by:yaodongdong@...wei.com

Acked-by: Eduardo Valentin <edubezval@...il.com>

Rui, would you take care of this?

> 
> ---
>  drivers/thermal/thermal_core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> index 71b0ec0..5b7d466 100644
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -1574,6 +1574,7 @@ struct thermal_zone_device *thermal_zone_device_register(const char *type,
>  unregister:
>     release_idr(&thermal_tz_idr, &thermal_idr_lock, tz->id);
>     device_unregister(&tz->device);
> +   kfree(tz);
>     return ERR_PTR(result);
>  }
>  EXPORT_SYMBOL_GPL(thermal_zone_device_register);
> --
> 1.8.0.1
> 
> 

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)