linux-kernel - Re: [PATCH] drivers: depend on instead of select BACKLIGHT_CLASS_DEVICE and ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 23 Oct 2014 14:38:54 +0300
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Daniel Vetter <daniel@...ll.ch>
CC:	Jani Nikula <jani.nikula@...el.com>,
	<linux-kernel@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
	<linuxppc-dev@...ts.ozlabs.org>,
	<platform-driver-x86@...r.kernel.org>, <linux-usb@...r.kernel.org>,
	<linux-fbdev@...r.kernel.org>, Jingoo Han <jg1.han@...sung.com>,
	Daniel Drake <dsd@...top.org>,
	Jens Frederich <jfrederich@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jon Nettleton <jon.nettleton@...il.com>,
	Randy Dunlap <rdunlap@...radead.org>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Darren Hart <dvhart@...radead.org>,
	Daniel Vetter <daniel.vetter@...el.com>,
	Bryan Wu <cooloney@...il.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Lee Jones <lee.jones@...aro.org>
Subject: Re: [PATCH] drivers: depend on instead of select BACKLIGHT_CLASS_DEVICE
 and ACPI_VIDEO

On 23/10/14 11:10, Daniel Vetter wrote:

> If we want to make BACKLIGHT_CLASS_DEVICE into a library thing then I
> guess we could do that, but we must then also drag it out of all the other
> meta options to make sure it's always available. No need I think to ditch

BACKLIGHT_CLASS_DEVICE only depends on HAS_IOMEM and
BACKLIGHT_LCD_SUPPORT so there are no other meta options to avoid.
HAS_IOMEM comes from drivers/video/Kconfig's "Graphics support", and I
guess we can ignore it.

> the entire BACKLIGHT_LCD_SUPPORT meta option. And then everyone could
> select it.

I don't quite understand what purpose does BACKLIGHT_LCD_SUPPORT serve.
It doesn't enable any code, it just opens up new Kconfig options. Why
can't the Kconfig options be always available? It's just another option
to 'select', without any reason I can see.

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)