lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Thu, 23 Oct 2014 20:38:05 +0530
From:	Sudip Mukherjee <>
To:	Jens Axboe <>
Subject: Re: [PATCH] block: wrong return value

On Thu, Oct 23, 2014 at 08:12:06AM -0600, Jens Axboe wrote:
> On 10/23/2014 07:20 AM, Sudip Mukherjee wrote:
> > while compiling integer err was showing as a set but unused variable.
> > elevator_init_fn can be either cfq_init_queue or deadline_init_queue
> > or noop_init_queue.
> > all three of these functions are returning -ENOMEM if they fail to
> > allocate the queue. 
> > so we should actually be returning the error code rather than
> > returning 0 always.
> That does look weird. You need an elevator_put() in the error case,
> though, ala:
oops.. sorry i missed that elevator_get in the code.
I will send you v2 of the patch.


> err = e->ops.elevator_init_fn(q, e);
> if (err)
> 	elevator_put(e);
> return err;
> -- 
> Jens Axboe
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists