lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 24 Oct 2014 10:50:07 +0300 From: Alexander Shishkin <alexander.shishkin@...ux.intel.com> To: Peter Zijlstra <peterz@...radead.org> Cc: Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org, Robert Richter <rric@...nel.org>, Frederic Weisbecker <fweisbec@...il.com>, Mike Galbraith <efault@....de>, Paul Mackerras <paulus@...ba.org>, Stephane Eranian <eranian@...gle.com>, Andi Kleen <ak@...ux.intel.com>, kan.liang@...el.com, adrian.hunter@...el.com, acme@...radead.org Subject: Re: [PATCH v5 12/20] x86: perf: intel_pt: Intel PT PMU driver Peter Zijlstra <peterz@...radead.org> writes: > On Mon, Oct 13, 2014 at 04:45:40PM +0300, Alexander Shishkin wrote: >> + if (test_cpu_cap(&boot_cpu_data, X86_FEATURE_INTEL_PT)) { >> + for (i = 0; i < PT_CPUID_LEAVES; i++) >> + cpuid_count(20, i, >> + &pt_pmu.caps[CR_EAX + i * 4], >> + &pt_pmu.caps[CR_EBX + i * 4], >> + &pt_pmu.caps[CR_ECX + i * 4], >> + &pt_pmu.caps[CR_EDX + i * 4]); >> + } else >> + return -ENODEV; > > Please use {} for every multi-line stmt, even if its a single stmt, also > use {} in both branches of a condition, even if only one strictly > requires it. Ok. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists