linux-kernel - Re: [PATCH] regulator: stub out devm_regulator_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141024192048.GB11455@saruman>
Date:	Fri, 24 Oct 2014 14:20:48 -0500
From:	Felipe Balbi <balbi@...com>
To:	Felipe Balbi <balbi@...com>
CC:	<broonie@...nel.org>, <lgirdwood@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	<airlied@...ux.ie>, <robdclark@...il.com>, <davidb@...eaurora.org>,
	<dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH] regulator: stub out devm_regulator_get_exclusive

On Fri, Oct 24, 2014 at 02:15:11PM -0500, Felipe Balbi wrote:
> If we don't stup that call out, we will have
> build failures for any drivers using that function
> when .config happens to have CONFIG_REGULATOR=n.
> 
> One such case below, found with randconfig
> 
> drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c: In function ‘mdp4_kms_init’:
> drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c:384:2: error: implicit declaration \
> 	of function ‘devm_regulator_get_exclusive’ [-Werror=implicit-function-declaration]
>   mdp4_kms->vdd = devm_regulator_get_exclusive(&pdev->dev, "vdd");
>   ^
> drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c:384:16: error: assignment makes \
> 	pointer from integer without a cast [-Werror]
>   mdp4_kms->vdd = devm_regulator_get_exclusive(&pdev->dev, "vdd");
>                 ^
> Signed-off-by: Felipe Balbi <balbi@...com>

randconfig attached.

-- 
balbi

View attachment "defconfig" of type "text/plain" (86519 bytes)

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)