linux-kernel - Re: [PATCH] regulator: stub out devm_regulator_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141024201138.GL3729@sirena.org.uk>
Date:	Fri, 24 Oct 2014 21:11:38 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Felipe Balbi <balbi@...com>
Cc:	lgirdwood@...il.com,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	airlied@...ux.ie, robdclark@...il.com, davidb@...eaurora.org,
	dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] regulator: stub out devm_regulator_get_exclusive

On Fri, Oct 24, 2014 at 02:15:11PM -0500, Felipe Balbi wrote:
> If we don't stup that call out, we will have
> build failures for any drivers using that function
> when .config happens to have CONFIG_REGULATOR=n.
> 
> One such case below, found with randconfig
> 
> drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c: In function ‘mdp4_kms_init’:
> drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c:384:2: error: implicit declaration \

As previously and repeatedly reported the regulator usage in this driver
appears extremely problematic, among these problems is that it almost
certainly has no sensible reason to be using regulator_get_exclusive()
or any variant of it.  Sadly every time it's been raised with the video
people they've completely ignored the mail so here we are.

Right now not having the stub seems to only be affecting buggy users
(which given the use cases for _exclusive() isn't *that* surprising) so
I'm more inclined to leave this there in the hope that the users get
fixed or we can at least get some sort of dialogue with the relevant
maintainers.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)