linux-kernel - Re: [PATCH] regulator: stub out devm_regulator_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF6AEGssn23wSaSCY-MH+CUk1YD2g7Ld+rejQq0BSHUAcXgZEQ@mail.gmail.com>
Date:	Fri, 24 Oct 2014 16:36:24 -0400
From:	Rob Clark <robdclark@...il.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	Felipe Balbi <balbi@...com>, lgirdwood@...il.com,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	David Airlie <airlied@...ux.ie>,
	David Brown <davidb@...eaurora.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH] regulator: stub out devm_regulator_get_exclusive

On Fri, Oct 24, 2014 at 4:11 PM, Mark Brown <broonie@...nel.org> wrote:
> On Fri, Oct 24, 2014 at 02:15:11PM -0500, Felipe Balbi wrote:
>> If we don't stup that call out, we will have
>> build failures for any drivers using that function
>> when .config happens to have CONFIG_REGULATOR=n.
>>
>> One such case below, found with randconfig
>>
>> drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c: In function ‘mdp4_kms_init’:
>> drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c:384:2: error: implicit declaration \
>
> As previously and repeatedly reported the regulator usage in this driver
> appears extremely problematic, among these problems is that it almost
> certainly has no sensible reason to be using regulator_get_exclusive()
> or any variant of it.  Sadly every time it's been raised with the video
> people they've completely ignored the mail so here we are.

oh, looks like a case of overambitious mailing list filter rules.. I
did not see the earlier threads on the topic.

iirc, I was using _get_exclusive() in a few places where I wanted to
be sure not to get dummy-regulator in cases where I should
-EPROBE_DEFER instead (since probe order with DT is slightly
hilarious, and since I depend on a few other drivers I end up
deferring at least a couple times at boot)... I don't quite remember
the details.  But afaict regulator_get() still allows dummy-regulator,
which is what I specifically don't want.

If you have a recommendation for a better way, I am all ears.

BR,
-R

> Right now not having the stub seems to only be affecting buggy users
> (which given the use cases for _exclusive() isn't *that* surprising) so
> I'm more inclined to leave this there in the hope that the users get
> fixed or we can at least get some sort of dialogue with the relevant
> maintainers.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/