linux-kernel - Re: [PATCH] regulator: stub out devm_regulator_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141024205840.GM3729@sirena.org.uk>
Date:	Fri, 24 Oct 2014 21:58:40 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Felipe Balbi <balbi@...com>
Cc:	lgirdwood@...il.com,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	airlied@...ux.ie, robdclark@...il.com, davidb@...eaurora.org,
	dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] regulator: stub out devm_regulator_get_exclusive

On Fri, Oct 24, 2014 at 03:18:27PM -0500, Felipe Balbi wrote:
> On Fri, Oct 24, 2014 at 09:11:38PM +0100, Mark Brown wrote:

> > Right now not having the stub seems to only be affecting buggy users
> > (which given the use cases for _exclusive() isn't *that* surprising) so
> > I'm more inclined to leave this there in the hope that the users get
> > fixed or we can at least get some sort of dialogue with the relevant
> > maintainers.

> quite frankly, flawed or not, I still think it's wrong of regulator
> framework to cause a build break during randconfig. Pretty much every
> other call is stubbed out, why wouldn't this be ? Moreover, if nobody

Well, it wasn't precisely a thought through choice before it happened
but when it was reported it wasn't obvious how someone could use a stub
(or what that stub should be) so I looked at the code and it just didn't
look at all sensible which made me think having the stub was a bad idea.

There are some bits of the regulator API which can quite happily be
stubbed out since the stub behaviour is within what could happen in
normal usage but there are other bits where the user really has to care
about what's happening and should probably depend on the regulator API,
this is one of the latter bits.

> cared to this day, why would this randconfig build break change their
> minds ?

For me it's more that I'm not terribly motivated to add code which only
serves to enable broken usage; it may be that there's a perfectly good
explanation for what the driver is doing but nobody seems to care about
it so...

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)