linux-kernel - Re: [vfs] WARNING: CPU: 3 PID: 2339 at mm/truncate.c:758 pagecache_isize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141027210523.GD6880@dastard>
Date:	Tue, 28 Oct 2014 08:05:23 +1100
From:	Dave Chinner <david@...morbit.com>
To:	Jan Kara <jack@...e.cz>
Cc:	Fengguang Wu <fengguang.wu@...el.com>,
	Theodore Ts'o <tytso@....edu>,
	LKML <linux-kernel@...r.kernel.org>, lkp@...org,
	"xfs@....sgi.com" <xfs@....sgi.com>,
	Linux-Fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [vfs] WARNING: CPU: 3 PID: 2339 at mm/truncate.c:758
 pagecache_isize_extended+0xdd/0x120()

On Mon, Oct 27, 2014 at 10:58:12AM +0100, Jan Kara wrote:
> On Mon 27-10-14 12:04:22, Dave Chinner wrote:
> > On Thu, Oct 16, 2014 at 01:01:27PM +0200, Jan Kara wrote:
> > > From de3426d6495f4b44b14c09b7c7202e9a86d864b9 Mon Sep 17 00:00:00 2001
> > > From: Jan Kara <jack@...e.cz>
> > > Date: Thu, 16 Oct 2014 12:58:42 +0200
> > > Subject: [PATCH] mm: Remove false WARN_ON from pagecache_isize_extended()
> > > 
> > > The WARN_ON checking whether i_mutex is held in
> > > pagecache_isize_extended() was wrong because some filesystems (e.g.
> > > XFS) use different locks for serialization of truncates / writes. So
> > > just remove the check.
> > > 
> > > Signed-off-by: Jan Kara <jack@...e.cz>
> > > ---
> > >  mm/truncate.c | 1 -
> > >  1 file changed, 1 deletion(-)
> > > 
> > > diff --git a/mm/truncate.c b/mm/truncate.c
> > > index 261eaf6e5a19..c646084e5eec 100644
> > > --- a/mm/truncate.c
> > > +++ b/mm/truncate.c
> > > @@ -755,7 +755,6 @@ void pagecache_isize_extended(struct inode *inode, loff_t from, loff_t to)
> > >  	struct page *page;
> > >  	pgoff_t index;
> > >  
> > > -	WARN_ON(!mutex_is_locked(&inode->i_mutex));
> > >  	WARN_ON(to > inode->i_size);
> > >  
> > >  	if (from >= to || bsize == PAGE_CACHE_SIZE)
> > 
> > Jan, Have you sent this patch upstream yet? I'm seeing it fire in
> > my testing in 3.18-rc1 kernels, so I was wondering what your plans
> > are for this...
>   I did send it but it got lost somewhere. I'll resend it.

If it comes to it, I can push it through the XFS tree - I've got a
few patches I need to send for -rc3...

Cheers,

Dave.
-- 
Dave Chinner
david@...morbit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/