linux-kernel - Re: [PATCH] staging: rtl8712: remove unused variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141027115221.GA5369@sudip-PC>
Date:	Mon, 27 Oct 2014 17:22:21 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Larry Finger <Larry.Finger@...inger.net>,
	Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8712: remove unused variables

On Mon, Oct 27, 2014 at 02:13:12PM +0300, Dan Carpenter wrote:
> On Sun, Oct 26, 2014 at 06:03:33PM +0530, Sudip Mukherjee wrote:
> > @@ -262,7 +257,7 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter)
> >  		if (tmp8_a != (tmp8|BIT(2)))
> >  			goto exit_fail;
> >  
> > -		tmp32 = r8712_read32(padapter, TCR);
> > +		r8712_read32(padapter, TCR);
> 
> I wonder if we actually need to call r8712_read32() here?  It's not
> clear.  The changelog should say one way or the other.  Maybe something
> like "I left a call to r8712_read32(padapter, TCR) because I didn't know
> if it had side effects".  When you note down questions you have in the
> changelog that helps reviewers.
sure. i will resend it with modified commit log.
r8712_read32() is ultimately calling usb_read32() which is again calling  r8712_usbctrl_vendorreq().
this r8712_usbctrl_vendorreq() is communicating through the usb bus and is sending and receiving the control msg.
that is why i didnot remove it.
> 
> > --- a/drivers/staging/rtl8712/rtl871x_pwrctrl.c
> > +++ b/drivers/staging/rtl8712/rtl871x_pwrctrl.c
> > @@ -156,11 +156,9 @@ static void rpwm_workitem_callback(struct work_struct *work)
> >  				       struct pwrctrl_priv, rpwm_workitem);
> >  	struct _adapter *padapter = container_of(pwrpriv,
> >  				    struct _adapter, pwrctrlpriv);
> > -	u8 cpwm = pwrpriv->cpwm;
> > -
> >  	if (pwrpriv->cpwm != pwrpriv->rpwm) {
> >  		_enter_pwrlock(&pwrpriv->lock);
> > -		cpwm = r8712_read8(padapter, SDIO_HCPWM);
> > +		r8712_read8(padapter, SDIO_HCPWM);
> 
> Same here.
same reason for r8712_read8().

thanks
sudip

> 
> >  		pwrpriv->rpwm_retry = 1;
> >  		r8712_set_rpwm(padapter, pwrpriv->rpwm);
> >  		up(&pwrpriv->lock);
> 
> regards,
> dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/