linux-kernel - Re: [PATCH] i386/audit: stop scribbling on the stack frame

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1414430984.24347.6.camel@redhat.com>
Date:	Mon, 27 Oct 2014 13:29:44 -0400
From:	Eric Paris <eparis@...hat.com>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Richard Guy Briggs <rgb@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-kernel@...r.kernel.org, przanoni@...il.com, mingo@...nel.org,
	hpa@...ux.intel.com, linux-tip-commits@...r.kernel.org,
	linux-audit@...hat.com
Subject: Re: [PATCH] i386/audit: stop scribbling on the stack frame

On Mon, 2014-10-27 at 10:02 -0700, H. Peter Anvin wrote:
> On 10/27/2014 06:55 AM, Eric Paris wrote:
> > My patch was already committed to the -tip urgent branch.  I believe any
> > optimization should be based on that branch, Richard.  If you are trying
> > to wrangle every bit of speed out of this, should you
> > 
> > push %esi;
> > push %edi;
> > CFI_ADJUST_CFA_OFFSET 8
> > call __audit_syscall_entry
> > pop;
> > pop;
> > CFI_ADJUST_CFA_OFFSET -8
> > 
> > Instead of using the pushl_cfi and popl_cfi macros?
> > 
> > I wrote my patch to be obviously correct, but agree there are certainly
> > some speedups possible.
> > 
> 
> Uh... not only is that plain wrong (the CFI should be adjusted after
> each instruction that changes the stack pointer),

Sure, things would be screwed up between the two push's

>  but what the heck is
> wrong with using the macros?

I was asking if that would save an instruction or two by consolidating
the CFI update and if so would that tradeoff be worth it, given the
regularity of this code being run.

> 
> 	-hpa
> 
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/