linux-kernel - Re: [PATCH] mmc/host/sdhci-of-arasan.c: Omit superfluous error messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 28 Oct 2014 10:49:25 +0100
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Mike Looijmans <mike.looijmans@...ic.nl>
Cc:	linux-mmc <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Michal Simek <michal.simek@...inx.com>,
	Chris Ball <chris@...ntf.net>
Subject: Re: [PATCH] mmc/host/sdhci-of-arasan.c: Omit superfluous error messages

On 28 October 2014 08:53, Mike Looijmans <mike.looijmans@...ic.nl> wrote:
> sdhci_add_host and sdhci_platfm_init already report failure,
> so don't emit error messages when a failure occurs. This prevents
> occurences of "deferred" messages when required power supplies
> are not ready for operation yet.
>
> Signed-off-by: Mike Looijmans <mike.looijmans@...ic.nl>

Thanks! Applied for next.

Kind regards
Uffe

> ---
>  drivers/mmc/host/sdhci-of-arasan.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index 7ac6718..75bea2e 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -161,7 +161,6 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
>         host = sdhci_pltfm_init(pdev, &sdhci_arasan_pdata, 0);
>         if (IS_ERR(host)) {
>                 ret = PTR_ERR(host);
> -               dev_err(&pdev->dev, "platform init failed (%d)\n", ret);
>                 goto clk_disable_all;
>         }
>
> @@ -171,10 +170,8 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
>         pltfm_host->clk = clk_xin;
>
>         ret = sdhci_add_host(host);
> -       if (ret) {
> -               dev_err(&pdev->dev, "platform register failed (%d)\n", ret);
> +       if (ret)
>                 goto err_pltfm_free;
> -       }
>
>         return 0;
>
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/