linux-kernel - Re: [tip:perf/urgent] perf/x86: Fix compile warnings for intel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141028124227.GR3337@twins.programming.kicks-ass.net>
Date:	Tue, 28 Oct 2014 13:42:28 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Andi Kleen <ak@...ux.intel.com>
Cc:	akpm@...ux-foundation.org, mingo@...nel.org, bp@...e.de,
	eranian@...gle.com, zheng.z.yan@...el.com, hpa@...or.com,
	tglx@...utronix.de, josh@...htriplett.org,
	linux-kernel@...r.kernel.org, linux-tip-commits@...r.kernel.org
Subject: Re: [tip:perf/urgent] perf/x86: Fix compile warnings for intel_uncore

On Tue, Oct 28, 2014 at 04:19:21AM -0700, Andi Kleen wrote:
> > +config PERF_EVENTS_INTEL_UNCORE
> > +	def_bool y
> 
> Why not give it a user name? It should be user configurable.

To avoid just that, another more or less pointless config option.

> > +	depends on PERF_EVENTS && SUP_SUP_INTEL && PCI
> 
> SUP_SUP_INTEL looks wrong. Should be CPU_SUP_INTEL
> 
> I suspect you disabled it completely.

Indeed, typo there.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/