lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 27 Oct 2014 17:34:26 -0700 From: Bjorn Andersson <bjorn.andersson@...ymobile.com> To: Jeffrey Hugo <jhugo@...eaurora.org> CC: Kumar Gala <galak@...eaurora.org>, Andy Gross <agross@...eaurora.org>, Arnd Bergmann <arnd@...db.de>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Grant Likely <grant.likely@...aro.org>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Lee Jones <lee.jones@...aro.org>, Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, Mark Rutland <mark.rutland@....com>, Pawel Moll <pawel.moll@....com>, Rob Herring <robh+dt@...nel.org>, Samuel Ortiz <sameo@...ux.intel.com>, Suman Anna <s-anna@...com> Subject: Re: [RFC 4/7] soc: qcom: Add Shared Memory Manager driver On Wed 08 Oct 14:33 PDT 2014, Jeffrey Hugo wrote: [..] > > + */ > > +struct smem_header { > > + struct smem_proc_comm proc_comm[4]; > > + u32 version[32]; > > + u32 smem_initialized; > > + u32 free_offset; > > + u32 available; > > + u32 unused; > > I see that you inlined the smem_heap_info struct. That is slightly > problematic since we have some uses of that structure, and without it, > accessing id 1 becomes complicated. I would prefer you reintroduce it. > Could you help me better understand what you mean here? I've scanned through msm-3.4 and msm-3.10 and read your comment numerous times, but I can't find any uses that needs it nor figure out why it would be difficult to access item 1. > > + struct smem_entry toc[SMEM_MAX_ITEMS]; > > +}; Thanks, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists