linux-kernel - Re: [PATCH] Add ltc3562 voltage regulator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141030120440.GW18557@sirena.org.uk>
Date:	Thu, 30 Oct 2014 12:04:40 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Mike Looijmans <mike.looijmans@...ic.nl>
Cc:	lgirdwood@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Add ltc3562 voltage regulator driver

On Thu, Oct 30, 2014 at 12:31:42PM +0100, Mike Looijmans wrote:
> On 10/30/2014 11:58 AM, Mark Brown wrote:

> >>Hmm, I looked into doing that, but that isn't trivial, and too many devices
> >>will suffer.

> >Why would this have a negative effect on other devices?  Unless somehow
> >the other devices add the property they should not be affected by it; if
> >users do add the property presumably that's because it's doing something
> >useful.

> The "default" would end up in the constraints, thus adding extra fields to
> that struct.

Sure, but why is that a problem?

> So far, all other drivers have accomplished this by setting min=max, and
> some experimenting proved that my driver is no exception to that. It even
> reduced the amount of code.

Yes, if you don't need to both set an initial voltage and support
voltage changing that works - it sounded like you needed both.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)