linux-kernel - Re: [PATCH] Add ltc3562 voltage regulator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5452219E.2070802@topic.nl>
Date:	Thu, 30 Oct 2014 12:31:42 +0100
From:	Mike Looijmans <mike.looijmans@...ic.nl>
To:	Mark Brown <broonie@...nel.org>
CC:	<lgirdwood@...il.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Add ltc3562 voltage regulator driver

On 10/30/2014 11:58 AM, Mark Brown wrote:
> On Thu, Oct 30, 2014 at 11:53:37AM +0100, Mike Looijmans wrote:
>> On 10/30/2014 11:29 AM, Mike Looijmans wrote:
>
>>> So I should add "regulator-default-voltage" to the generic code? That would
>>> indeed be better than trying to do it into this driver.
>
>>> But would that need a separate patch for regulator core to add the property?
>
> Yes.
>
>> Hmm, I looked into doing that, but that isn't trivial, and too many devices
>> will suffer.
>
> Why would this have a negative effect on other devices?  Unless somehow
> the other devices add the property they should not be affected by it; if
> users do add the property presumably that's because it's doing something
> useful.

The "default" would end up in the constraints, thus adding extra fields to 
that struct.

So far, all other drivers have accomplished this by setting min=max, and some 
experimenting proved that my driver is no exception to that. It even reduced 
the amount of code.

Mike.



Met vriendelijke groet / kind regards,

Mike Looijmans
System Expert


TOPIC Embedded Systems
Eindhovenseweg 32-C, NL-5683 KH Best
Postbus 440, NL-5680 AK Best
Telefoon: (+31) (0) 499 33 69 79
Telefax:  (+31) (0) 499 33 69 70
E-mail: mike.looijmans@...ic.nl
Website: www.topic.nl

Please consider the environment before printing this e-mail

Topic zoekt gedreven (embedded) software specialisten!
http://topic.nl/vacatures/topic-zoekt-software-engineers/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/