linux-kernel - Re: [PATCH v4 04/14] perf tools: Add kbuild support into Makefile.kbuild

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141031083427.GB27472@krava.brq.redhat.com>
Date:	Fri, 31 Oct 2014 09:34:27 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Alexis Berlemont <alexis.berlemont@...il.com>
Cc:	linux-kernel@...r.kernel.org, dsahern@...il.com, mingo@...hat.com,
	a.p.zijlstra@...llo.nl, paulus@...ba.org, acme@...nel.org,
	namhyung@...nel.org, mmarek@...e.cz,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Ingo Molnar <mingo@...e.hu>,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Borislav Petkov <bp@...en8.de>, linux-kbuild@...r.kernel.org,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH v4 04/14] perf tools: Add kbuild support into
 Makefile.kbuild

On Thu, Oct 30, 2014 at 12:05:07AM +0100, Alexis Berlemont wrote:

SNIP

> > >  tools/perf/util/Kbuild                             | 126 ++++++
> > >  tools/perf/util/PERF-VERSION-GEN                   |   4 +
> > >  tools/perf/util/generate-cmdlist.sh                |   8 +-
> > >  tools/perf/util/scripting-engines/Kbuild           |  11 +
> > >  tools/perf/util/setup.py                           |   8 +-
> > 
> > so this patch took the perf Makefile (at that time) and changed it to
> > use the kbuild.. but since that time the Makefile.perf came and many
> > other changes, which need to be reflected in Makefile.kbuild
> > 
> > I need to revisit the logic and split the change into more incremental
> > patches (the patchset is too big)
> > 
> > I can redo patches 2,3,4 and get back to you, sounds ok?
> 
> Of course. 
> 
> Which changes in Makefile.perf do you have in mind ? I thought that
> Makefile.kbuild was just supposed to build the few extra dependencies
> (libtraceevent, etc.). I thought that I updated your original patch
> accordingly with the changes before and after the add of
> Makefile.perf.

hm, I just stumbled on QUIET_* stuff definitions in Makefile.kbuild,
(which got moved into scripts some time ago) and assumed this was
the case for the rest of the file ;-)

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/