linux-kernel - arch/microblaze/kernel/head.S: redundant code?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAN628AF+h9CnfFqMyRHKx=8E9egvcB0rd+_oCY4Q-4gq4NMn=Q@mail.gmail.com>
Date:	Fri, 31 Oct 2014 15:22:39 +0000
From:	Adrian McMenamin <lkmladrian@...il.com>
To:	LKML <linux-kernel@...r.kernel.org>
Cc:	monstr@...str.eu
Subject: arch/microblaze/kernel/head.S: redundant code?

Looking at this code at line 78 (in 3.17 kernel) it has:

    mfs r1, rmsr
    msrclr r8, 0
    cmpu r8, r8, r1

But as far as I can see the result of that comparison is never used -
the comments state it is to test if the msrclr  instruction is
enabled.

Haven't posted a patch because I am using the code to understand how
to write my own boot code for a very specific Microblaze application -
but perhaps someone with real expertise could look and/or tell me I'm
wrong?

Cheers

Adrian

(apologies to Michal Simek for getting this twice)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/