linux-kernel - Re: Microblaze arch/microblaze/kernel/head.S: redundant code?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <5453A961.6020900@monstr.eu>
Date:	Fri, 31 Oct 2014 16:23:13 +0100
From:	Michal Simek <monstr@...str.eu>
To:	Adrian McMenamin <lkmladrian@...il.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: Microblaze arch/microblaze/kernel/head.S: redundant code?

Hi,

On 10/31/2014 04:15 PM, Adrian McMenamin wrote:
> Looking at this code at line 78 (in 3.17 kernel) it has:
> 
>     mfs r1, rmsr
>     msrclr r8, 0
>     cmpu r8, r8, r1
> 
> But as far as I can see the result of that comparison is never used - the
> comments state it is to test if the msrclr  instruction is enabled.

r8 is used when machine_early_init() is called.
r8 is 4th register which is used for passing args based on Microblaze
reference manual.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)