| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 1 Nov 2014 10:38:51 +0530
From: Sudip Mukherjee <sudipm.mukherjee@...il.com>
To: Chen Weixiang <weixiangchen@...il.com>
Cc: Marek Belisko <marek.belisko@...il.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Chen Weixiang <weixiang.chen@...il.com>,
Aybuke Ozdemir <aybuke.147@...il.com>,
Felipe Balbi <balbi@...com>, Nicolas Thery <nthery@...il.com>,
Greg Donald <gdonald@...il.com>,
Daniel Dodge <danieldodgese@...il.com>,
Wilfried Klaebe <w-lkml@...enslange-mailadresse.de>,
devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/6] staging: ft1000: space prohibited after '(', '&'
and before ')'
On Sat, Nov 01, 2014 at 10:47:23AM +0800, Chen Weixiang wrote:
> Remove following code style errors from ft1000/ft1000-pcmcia/ft1000_hw.c:
> ERROR: space prohibited after that open parenthesis '('
> ERROR: space prohibited before that close parenthesis ')'
> ERROR: space prohibited after that '&' (ctx:WxW)
>
> Signed-off-by: Chen Weixiang <weixiang.chen@...il.com>
> ---
> drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 32 ++++++++++++------------
> 1 file changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
> index fc28dee..9ef7817 100644
> --- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
> +++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
> @@ -888,7 +888,7 @@ static bool ft1000_receive_cmd(struct net_device *dev, u16 *pbuffer,
> unsigned long flags;
>
> if (info->AsicID == ELECTRABUZZ_ID) {
> - size = ( ft1000_read_dpram(dev, *pnxtph) ) + sizeof(struct pseudo_hdr);
> + size = (ft1000_read_dpram(dev, *pnxtph)) + sizeof(struct pseudo_hdr);
line over 80 char.
> } else {
> size =
> ntohs(ft1000_read_dpram_mag_16
> @@ -998,10 +998,10 @@ static void ft1000_proc_drvmsg(struct net_device *dev)
> else {
> tempword = FT1000_DPRAM_MAG_RX_BASE;
> }
> - if ( ft1000_receive_cmd(dev, &cmdbuffer[0], MAX_CMD_SQSIZE, &tempword) ) {
> + if (ft1000_receive_cmd(dev, &cmdbuffer[0], MAX_CMD_SQSIZE, &tempword)) {
whitespace at the beginning of the line.
thanks
sudip
>
> /* Get the message type which is total_len + PSEUDO header + msgtype + message body */
> - pdrvmsg = (struct drv_msg *) & cmdbuffer[0];
> + pdrvmsg = (struct drv_msg *) &cmdbuffer[0];
> msgtype = ntohs(pdrvmsg->type);
> DEBUG(1, "Command message type = 0x%x\n", msgtype);
> switch (msgtype) {
> @@ -1055,7 +1055,7 @@ static void ft1000_proc_drvmsg(struct net_device *dev)
> info->CardReady = 1;
> break;
> case MEDIA_STATE:
> - pmediamsg = (struct media_msg *) & cmdbuffer[0];
> + pmediamsg = (struct media_msg *) &cmdbuffer[0];
> if (info->ProgConStat != 0xFF) {
> if (pmediamsg->state) {
> DEBUG(1, "Media is up\n");
> @@ -1087,7 +1087,7 @@ static void ft1000_proc_drvmsg(struct net_device *dev)
> }
> break;
> case DSP_INIT_MSG:
> - pdspinitmsg = (struct dsp_init_msg *) & cmdbuffer[0];
> + pdspinitmsg = (struct dsp_init_msg *) &cmdbuffer[0];
> memcpy(info->DspVer, pdspinitmsg->DspVer, DSPVERSZ);
> DEBUG(1, "DSPVER = 0x%2x 0x%2x 0x%2x 0x%2x\n",
> info->DspVer[0], info->DspVer[1], info->DspVer[2],
> @@ -1121,7 +1121,7 @@ static void ft1000_proc_drvmsg(struct net_device *dev)
> tempword = ntohs(pdrvmsg->length);
> info->DSPInfoBlklen = tempword;
> if (tempword < (MAX_DSP_SESS_REC - 4)) {
> - pmsg = (u16 *) & pdrvmsg->data[0];
> + pmsg = (u16 *) &pdrvmsg->data[0];
> for (i = 0; i < ((tempword + 1) / 2); i++) {
> DEBUG(1,
> "FT1000:drivermsg:dsp info data = 0x%x\n",
> @@ -1203,7 +1203,7 @@ static void ft1000_proc_drvmsg(struct net_device *dev)
> * Put message into Slow Queue
> * Form Pseudo header
> */
> - pmsg = (u16 *) & tempbuffer[0];
> + pmsg = (u16 *) &tempbuffer[0];
> ppseudo_hdr = (struct pseudo_hdr *) pmsg;
> ppseudo_hdr->length = htons(0x0012);
> ppseudo_hdr->source = 0x10;
> @@ -1224,7 +1224,7 @@ static void ft1000_proc_drvmsg(struct net_device *dev)
> for (i = 1; i < 7; i++) {
> ppseudo_hdr->checksum ^= *pmsg++;
> }
> - pmsg = (u16 *) & tempbuffer[16];
> + pmsg = (u16 *) &tempbuffer[16];
> *pmsg++ = htons(RSP_DRV_ERR_RPT_MSG);
> *pmsg++ = htons(0x000e);
> *pmsg++ = htons(info->DSP_TIME[0]);
> @@ -1880,22 +1880,22 @@ static int ft1000_copy_down_pkt(struct net_device *dev, u16 * packet, u16 len)
> i + 8, htons(*packet));
> }
> } else {
> - outl(*(u32 *) & pseudo.buff[0],
> + outl(*(u32 *) &pseudo.buff[0],
> dev->base_addr + FT1000_REG_MAG_UFDR);
> DEBUG(1, "ft1000_copy_down_pkt: Pseudo = 0x%8x\n",
> - *(u32 *) & pseudo.buff[0]);
> - outl(*(u32 *) & pseudo.buff[2],
> + *(u32 *) &pseudo.buff[0]);
> + outl(*(u32 *) &pseudo.buff[2],
> dev->base_addr + FT1000_REG_MAG_UFDR);
> DEBUG(1, "ft1000_copy_down_pkt: Pseudo = 0x%8x\n",
> - *(u32 *) & pseudo.buff[2]);
> - outl(*(u32 *) & pseudo.buff[4],
> + *(u32 *) &pseudo.buff[2]);
> + outl(*(u32 *) &pseudo.buff[4],
> dev->base_addr + FT1000_REG_MAG_UFDR);
> DEBUG(1, "ft1000_copy_down_pkt: Pseudo = 0x%8x\n",
> - *(u32 *) & pseudo.buff[4]);
> - outl(*(u32 *) & pseudo.buff[6],
> + *(u32 *) &pseudo.buff[4]);
> + outl(*(u32 *) &pseudo.buff[6],
> dev->base_addr + FT1000_REG_MAG_UFDR);
> DEBUG(1, "ft1000_copy_down_pkt: Pseudo = 0x%8x\n",
> - *(u32 *) & pseudo.buff[6]);
> + *(u32 *) &pseudo.buff[6]);
>
> plong = (u32 *) packet;
> /* Write PPP type + IP Packet into Downlink FIFO */
> --
> 2.1.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists