lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20141101051031.GE3642@sudip-PC>
Date:	Sat, 1 Nov 2014 10:40:31 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Chen Weixiang <weixiangchen@...il.com>
Cc:	Marek Belisko <marek.belisko@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Chen Weixiang <weixiang.chen@...il.com>,
	Aybuke Ozdemir <aybuke.147@...il.com>,
	Felipe Balbi <balbi@...com>, Nicolas Thery <nthery@...il.com>,
	Greg Donald <gdonald@...il.com>,
	Daniel Dodge <danieldodgese@...il.com>,
	Wilfried Klaebe <w-lkml@...enslange-mailadresse.de>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/6] staging: ft1000: "(foo*)" should be "(foo *)"

On Sat, Nov 01, 2014 at 10:47:24AM +0800, Chen Weixiang wrote:
> Remove following code style error from ft1000/ft1000-usb/ft1000_debug.c:
> ERROR: "(foo*)" should be "(foo *)"
> 
again checkpatch gives total: 4 errors, 3 warnings, 16 lines checked.
this includes whitespace errors.

thanks
sudip

> Signed-off-by: Chen Weixiang <weixiang.chen@...il.com>
> ---
>  drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c b/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c
> index 02bfb3e..7bc05fe 100644
> --- a/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c
> +++ b/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c
> @@ -447,7 +447,7 @@ static long ft1000_ioctl(struct file *file, unsigned int command,
>      switch (cmd) {
>      case IOCTL_REGISTER_CMD:
>              DEBUG("FT1000:ft1000_ioctl: IOCTL_FT1000_REGISTER called\n");
> -            result = get_user(tempword, (__u16 __user*)argp);
> +            result = get_user(tempword, (__u16 __user *)argp);
>              if (result) {
>                  DEBUG("result = %d failed to get_user\n", result);
>                  break;
> @@ -652,7 +652,7 @@ static long ft1000_ioctl(struct file *file, unsigned int command,
>                              }
>                              pmsg++;
>  				ppseudo_hdr = (struct pseudo_hdr *)pmsg;
> -                           result = card_send_command(ft1000dev,(unsigned short*)dpram_data,total_len+2);
> +                           result = card_send_command(ft1000dev,(unsigned short *)dpram_data,total_len+2);
>  
>  
>                              ft1000dev->app_info[app_index].nTxMsg++;
> -- 
> 2.1.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ