linux-kernel - Re: [PATCH 3.2 023/102] block: Fix dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5456D944.90905@fb.com>
Date:	Sun, 2 Nov 2014 18:24:20 -0700
From:	Jens Axboe <axboe@...com>
To:	Ben Hutchings <ben@...adent.org.uk>
CC:	<linux-kernel@...r.kernel.org>, <stable@...r.kernel.org>,
	<akpm@...ux-foundation.org>, Keith Busch <keith.busch@...el.com>
Subject: Re: [PATCH 3.2 023/102] block: Fix dev_t minor allocation lifetime

On 2014-11-01 17:48, Ben Hutchings wrote:
> On Sat, 2014-11-01 at 17:18 -0600, Jens Axboe wrote:
>> On 2014-11-01 16:28, Ben Hutchings wrote:
>>> 3.2.64-rc1 review patch.  If anyone has any objections, please let me know.
>>>
>>> ------------------
>>>
>>> From: Keith Busch <keith.busch@...el.com>
>>>
>>> commit 2da78092dda13f1efd26edbbf99a567776913750 upstream.
>>>
>>> Releases the dev_t minor when all references are closed to prevent
>>> another device from acquiring the same major/minor.
>>>
>>> Since the partition's release may be invoked from call_rcu's soft-irq
>>> context, the ext_dev_idr's mutex had to be replaced with a spinlock so
>>> as not so sleep.
>>>
>>> Signed-off-by: Keith Busch <keith.busch@...el.com>
>>> Signed-off-by: Jens Axboe <axboe@...com>
>>> [bwh: Backported to 3.2:
>>>    - Adjust filename
>>>    - idr insertion API is different, and blk_alloc_devt() is preallocating
>>>      a node in a different way]
>>
>> As I've noted for pretty much every stable branch so far, you have to
>> backport commit 46f341ffcfb5 as well, if you backport this one.
>
> I'm not caught up on reading the stable list, so I missed that.  Thanks
> for pointing it out again; I'll add it.

Thanks, it keeps biting me in the ass that I didn't get a Fixes: added 
to that patch...


-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/