linux-kernel - Re: [PATCH v4 1/8] ARM: mediatek: Add basic support for mt8127

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4360790.RbZnni9y9f@wuerfel>
Date:	Tue, 04 Nov 2014 10:45:40 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Matthias Brugger <matthias.bgg@...il.com>
Cc:	HC Yen <hc.yen@...iatek.com>, "Joe. C" <yingjoe.chen@...iatek.com>,
	Rob Herring <robh+dt@...nel.org>, arm@...nel.org,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Russell King <linux@....linux.org.uk>,
	Olof Johansson <olof@...om.net>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	srv_heupstream <srv_heupstream@...iatek.com>,
	Yingjoe Chen <yingjoe.chen@...il.com>,
	huang eddie <eddie.huang@...iatek.com>,
	Nathan Chung <nathan.chung@...iatek.com>,
	Yuhau Chen <yh.chen@...iatek.com>,
	Sascha Hauer <kernel@...gutronix.de>
Subject: Re: [PATCH v4 1/8] ARM: mediatek: Add basic support for mt8127

On Tuesday 04 November 2014 09:36:39 Matthias Brugger wrote:
> 2014-11-04 8:39 GMT+01:00 Arnd Bergmann <arnd@...db.de>:
> > On Tuesday 04 November 2014 14:36:45 HC Yen wrote:
> >> > > +
> >> > > +#include <dt-bindings/interrupt-controller/irq.h>
> >> > > +#include <dt-bindings/interrupt-controller/arm-gic.h>
> >> > > +#include "skeleton64.dtsi"
> >> >
> >> > Cortex a7 is 32 bits, right? So why do you use skeleton64.dtsi?
> >>
> >> Cortex-A7 is 32-bit, but that doesn't mean it can only have 32-bit
> >> physical address.  With LPAE enabled, we can have physical address more
> >> than 32 bits.
> >>
> >> The main difference between "skeleton64.dtsi" and "skeleton.dtsi" is
> >> "#address-cells" property set to 2.  Although there are few sources
> >> using "skeleton64.dtsi", some of them write "#address-cells = <2>"
> >> directly in order to have 64-bit address space.  ARM's TC2 reference
> >> platform (vexpress-v2p-ca15_a7.dts) is an example.
> >>
> >> Some of MediaTek ARMv7 SoCs support address space larger than 4GB. It
> >> will be convenient to share the sources if we all use 64-bit device
> >> tree.
> >
> > Right, in general, I'd use #address-cells=<2> for Cortex-A7/A15/A17.
> 
> Alright, thanks for clarification. So we should use skeleton64.dtsi
> for mt6589 as well, right?

If the chip is capable of accessing memory or registers higher than 4GB
physical address, then you should, yes.

If the SoC has limitations that mean you can't have higher addresses
anyway, then either way is fine, no need to change it.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/