linux-kernel - Re: [PATCH] mfd: db8500-prcmu: Provide sane error path values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdb-6-cjHhtLMNf_jevqqmew9u0OAL-rpFd5mfiwK6C6Ww@mail.gmail.com>
Date:	Tue, 4 Nov 2014 11:13:50 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	Fabio Estevam <festevam@...il.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mfd: db8500-prcmu: Provide sane error path values

On Mon, Nov 3, 2014 at 5:50 PM, Lee Jones <lee.jones@...aro.org> wrote:
> On Mon, 03 Nov 2014, Fabio Estevam wrote:
>
>> On Mon, Nov 3, 2014 at 2:15 PM, Lee Jones <lee.jones@...aro.org> wrote:
>>
>> >         /* Clean up the mailbox interrupts after pre-kernel code. */
>> > @@ -3179,15 +3179,14 @@ static int db8500_prcmu_probe(struct platform_device *pdev)
>> >         irq = platform_get_irq(pdev, 0);
>> >         if (irq <= 0) {
>>
>> Shouldn't this be if (irq < 0) then?
>
> Perhaps Linus can answer that.
>
> Linus,
>
>   Is 0 a valid IRQ on the u8500 platform or not?

It is not. 0 is NO_IRQ and should be so for every system... just
the lazy and ancient ones lag behind.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/