linux-kernel - Re: [PATCH v1 10/11] backports: prefix c-file / h-file auto backport with BPAUTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1415096092.2064.13.camel@sipsolutions.net>
Date:	Tue, 04 Nov 2014 11:14:52 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	"Luis R. Rodriguez" <mcgrof@...not-panic.com>
Cc:	backports@...r.kernel.org, linux-kernel@...r.kernel.org,
	yann.morin.1998@...e.fr, mmarek@...e.cz, sassmann@...nic.de,
	"Luis R. Rodriguez" <mcgrof@...e.com>
Subject: Re: [PATCH v1 10/11] backports: prefix c-file / h-file auto
 backport with BPAUTO

On Tue, 2014-11-04 at 00:43 -0800, Luis R. Rodriguez wrote:

> -            mf.write('compat-$(%s%s) += %s\n' % (bp_prefix, sym, ' '.join(o_files)))
> +            if bp_prefix not in sym:
> +                mf.write('compat-$(%s%s) += %s\n' % (bp_prefix, sym, ' '.join(o_files)))
> +            else:
> +                mf.write('compat-$(%s) += %s\n' % (sym, ' '.join(o_files)))

I don't think these changes are correct, the bp_prefix is needed anyway,
and there's no way it could already be. Looks like this comes from a
previous attempt where you misunderstood and thought
CONFIG_BACKPORT_BACKPORT_... was actually wrong, when in fact it is
correct (and would now be CONFIG_BACKPORT_BPAUTO_...)

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/