[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <54609DD8.8030903@cogentembedded.com>
Date: Mon, 10 Nov 2014 14:13:28 +0300
From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To: Wenyou Yang <wenyou.yang@...el.com>, wsa@...-dreams.de,
ludovic.desroches@...el.com
CC: khilman@...nel.org, nicolas.ferre@...el.com,
linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v4] i2c/at91: adopt pinctrl support
Hello.
On 11/10/2014 4:55 AM, Wenyou Yang wrote:
> Amend the at91 i2c pin controller
You're amending the hardware itself, really? :-)
> to optionally take a pin controlhandle
I don't see the code that does this.
> and set the state of the pins to:
> - "default" on boot and resume.
I don't see where you are changing anything for the probe() method.
Perhaps you meant the driver core code which selects the dafault profile
automatically?
> - "sleep" on suspend().
> This should make it possible to optimize energy usage for the pins
> both for the suspend/resume cycle
> Signed-off-by: Wenyou Yang <wenyou.yang@...el.com>
> ---
> Hi Wolfram,
>
> Thanks a lot.
>
> The change of this version is to remove
> pinctrl_pm_select_default_state(&pdev->dev) from the _probe function.
Aha, you've specifically removed this...
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists