linux-kernel - RE: [PATCH v4] i2c/at91: adopt pinctrl support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Nov 2014 00:53:58 +0000
From:	"Yang, Wenyou" <Wenyou.Yang@...el.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	"wsa@...-dreams.de" <wsa@...-dreams.de>,
	"Desroches, Ludovic" <Ludovic.Desroches@...el.com>
CC:	"khilman@...nel.org" <khilman@...nel.org>,
	"Ferre, Nicolas" <Nicolas.FERRE@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH v4] i2c/at91: adopt pinctrl support

Hi,

> -----Original Message-----
> From: Sergei Shtylyov [mailto:sergei.shtylyov@...entembedded.com]
> Sent: Monday, November 10, 2014 7:13 PM
> To: Yang, Wenyou; wsa@...-dreams.de; Desroches, Ludovic
> Cc: khilman@...nel.org; Ferre, Nicolas; linux-kernel@...r.kernel.org; linux-
> i2c@...r.kernel.org; linux-arm-kernel@...ts.infradead.org
> Subject: Re: [PATCH v4] i2c/at91: adopt pinctrl support
> 
> Hello.
> 
> On 11/10/2014 4:55 AM, Wenyou Yang wrote:
> 
> > Amend the at91 i2c pin controller
> 
>     You're amending the hardware itself, really? :-)
> 
> > to optionally take a pin controlhandle
> 
>     I don't see the code that does this.
> 
> > and set the state of the pins to:
> > - "default" on boot and resume.
> 
>     I don't see where you are changing anything for the probe() method.
> Perhaps you meant the driver core code which selects the dafault profile
> automatically?
Yes, the driver core code default do, so remove the redundant code from _probe function.

> 
> > - "sleep" on suspend().
> 
> > This should make it possible to optimize energy usage for the pins
> > both for the suspend/resume cycle
> 
> > Signed-off-by: Wenyou Yang <wenyou.yang@...el.com>
> > ---
> > Hi Wolfram,
> >
> > Thanks a lot.
> >
> > The change of this version is to remove
> > 	pinctrl_pm_select_default_state(&pdev->dev) from the _probe function.
> 
>     Aha, you've specifically removed this...
> 
> WBR, Sergei

Best Regards,
Wenyou Yang

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/