linux-kernel - Re: [PATCH 2/3] ASoC: twl4030: allow voice port to be connected externally.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141110121155.GN3815@sirena.org.uk>
Date:	Mon, 10 Nov 2014 12:11:55 +0000
From:	Mark Brown <broonie@...nel.org>
To:	NeilBrown <neilb@...e.de>
Cc:	Mark Rutland <mark.rutland@....com>,
	Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Liam Girdwood <lgirdwood@...il.com>,
	Rob Herring <robh+dt@...nel.org>,
	Peter Ujfalusi <peter.ujfalusi@...com>,
	GTA04 owners <gta04-owner@...delico.com>,
	devicetree@...r.kernel.org, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] ASoC: twl4030: allow voice port to be connected
 externally.

On Mon, Nov 10, 2014 at 10:25:51AM +1100, NeilBrown wrote:

> says it is a "reference platform".  Does that mean it is a board with a bunch
> of chips soldered onto it?  If it were a board it should be described by a
> dts file, not by a pile of C code (I thought), so I must be wrong about that.

No, like I say please see previous discussion ad nauseum about this.

> The twl4030 needs to know the master/polarity of the clk/frm lines.  The GSM
> module declares that these are.  So presumably we need some sort of linkage.
> Ahhhh... I found Documentation/devicetree/bindings/sound/simple-card.txt

Or just write a machine driver.  simple-card is one such machine driver
but it's not going to be suitable for non-trivial systems.  Possibly
your system is simple enough, possibly it isn't - I don't know anything
about it really.  Regardless of how you do this it shouldn't have
individual devices needing to open code configuration for links, it's
something essentially every device is going to need to do and forcing
the DT to configure the same thing twice for a link isn't a good idea
either.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)