lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 10 Nov 2014 13:13:49 +0100 From: Ingo Molnar <mingo@...nel.org> To: Jan Beulich <JBeulich@...e.com> Cc: linux-kernel@...r.kernel.org, Steven Rostedt <rostedt@...dmis.org>, akpm@...ux-foundation.org, mingo@...hat.com, Peter Zijlstra <a.p.zijlstra@...llo.nl> Subject: Re: [PATCH] irqflags: fix (at least latent) code generation issue * Jan Beulich <JBeulich@...e.com> wrote: > The conditional in local_irq_restore() otherwise can cause code bloat > (the if and else blocks may get translated into separate code paths > despite the generated code being identical, dependent on compiler > internal heuristics). Note that this adjustment gets the code in sync > with the comment preceding it (which was slightly wrong from at least > from 2.6.37 onwards). > > The code bloat was observed in reality with an experimental x86 patch > I'm about to post as RFC. > > Signed-off-by: Jan Beulich <jbeulich@...e.com> > --- > include/linux/irqflags.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > --- 3.18-rc3/include/linux/irqflags.h > +++ 3.18-rc3-irqflags/include/linux/irqflags.h > @@ -85,7 +85,7 @@ > * The local_irq_*() APIs are equal to the raw_local_irq*() > * if !TRACE_IRQFLAGS. > */ > -#ifdef CONFIG_TRACE_IRQFLAGS_SUPPORT > +#ifdef CONFIG_TRACE_IRQFLAGS > #define local_irq_enable() \ > do { trace_hardirqs_on(); raw_local_irq_enable(); } while (0) > #define local_irq_disable() \ > @@ -131,7 +131,7 @@ > } while (0) > > > -#else /* !CONFIG_TRACE_IRQFLAGS_SUPPORT */ > +#else /* !CONFIG_TRACE_IRQFLAGS */ > > #define local_irq_enable() do { raw_local_irq_enable(); } while (0) > #define local_irq_disable() do { raw_local_irq_disable(); } while (0) > @@ -145,6 +145,6 @@ > #define irqs_disabled_flags(flags) (raw_irqs_disabled_flags(flags)) > #define safe_halt() do { raw_safe_halt(); } while (0) > > -#endif /* CONFIG_TRACE_IRQFLAGS_SUPPORT */ > +#endif /* CONFIG_TRACE_IRQFLAGS */ So this breaks a couple of non-x86 architectures, such as MIPS: /home/mingo/tip/include/acpi/platform/aclinuxex.h: In function 'acpi_os_allocate': /home/mingo/tip/include/acpi/platform/aclinuxex.h:86: error: implicit declaration of function 'arch_irqs_disabled' Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists