linux-kernel - Re: [PATCH v2 1/2] i2c: add support for Amlogic Meson I2C controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141110144440.GB10422@katana>
Date:	Mon, 10 Nov 2014 15:44:41 +0100
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Beniamino Galvani <b.galvani@...il.com>
Cc:	Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Grant Likely <grant.likely@...aro.org>,
	Carlo Caione <carlo@...one.org>, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	Jerry Cao <jerry.cao@...ogic.com>,
	Victor Wan <victor.wan@...ogic.com>
Subject: Re: [PATCH v2 1/2] i2c: add support for Amlogic Meson I2C controller

On Sun, Oct 05, 2014 at 10:17:11PM +0200, Beniamino Galvani wrote:
> This is a driver for the I2C controller found in Amlogic Meson SoCs.
> 
> Signed-off-by: Beniamino Galvani <b.galvani@...il.com>

Thanks. Looking very good already!

> +static void meson_i2c_prepare_xfer(struct meson_i2c *i2c, bool write)

Instead of the bool, maybe you could query i2c->state in the function?
You decide, I am not forcing you to do this.

> +static u32 meson_i2c_func(struct i2c_adapter *adap)
> +{
> +	return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL;
> +}

Have you tested 0-byte transfers, too (i2cdetect -q)? What was your test
scenario in general?

Just minor questions. It is good to go already!


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)