linux-kernel - Re: [RFD] perf syscall error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141110144704.GA24040@gmail.com>
Date:	Mon, 10 Nov 2014 15:47:04 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	David Ahern <dsahern@...il.com>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Vince Weaver <vince@...ter.net>,
	Stephane Eranian <eranian@...gle.com>,
	Jiri Olsa <jolsa@...hat.com>,
	Andy Lutomirski <luto@...capital.net>,
	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFD] perf syscall error handling


* David Ahern <dsahern@...il.com> wrote:

> On 11/10/14, 5:24 AM, Ingo Molnar wrote:
> >Programmatic use in user-spaec is very simple - go with my
> >initial example, tooling can either just display the error string
> >and bail out, or do:
> >
> >   if (unlikely(error)) {
> >	if (!strcmp(attr->error_str, "x86/bts: BTS not supported by this CPU architecture")) {
> >		fprintf(stderr, "x86/BTS: No hardware support falling back to branch sampling\n");
> >		activate_x86_bts_fallback_code();
> >		goto out;
> >	}
> 
> That makes the exact string content part of the ABI. [...]

That's ok: messages might still disappear, new messages might 
still be introduced.

> [...] As I recall ftrace had a problem with format strings 
> changing and tooling then limiting the ability to change it.

I think there's a real difference between extended strings 
provided by an error/exception path (perf) and strings provided 
by the primary ABI (ftrace).

In the first case tooling is still functional without extended 
strings, in the second case ftrace tooling is useless if it 
cannot interpret the ftrace string output.

So it's apples to oranges.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/