linux-kernel - Re: usb: gadget: midi: f_midi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141112150057.GD641@saruman>
Date:	Wed, 12 Nov 2014 09:00:57 -0600
From:	Felipe Balbi <balbi@...com>
To:	Fengguang Wu <fengguang.wu@...el.com>
CC:	Felipe Balbi <balbi@...com>,
	Andrzej Pietrasiewicz <andrzej.p@...sung.com>,
	LKML <linux-kernel@...r.kernel.org>,
	"Linux USB Mailing List" <linux-usb@...r.kernel.org>
Subject: Re: usb: gadget: midi: f_midi_alloc() can be static

On Wed, Nov 12, 2014 at 09:28:24PM +0800, Fengguang Wu wrote:
> drivers/usb/gadget/function/f_midi.c:1072:21: sparse: symbol 'f_midi_alloc' was not declared. Should it be static?
> drivers/usb/gadget/legacy/gmidi.c:118:30: sparse: symbol 'fi_midi' was not declared. Should it be static?
> drivers/usb/gadget/legacy/gmidi.c:119:21: sparse: symbol 'f_midi' was not declared. Should it be static?
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>

I'm taking this one, but next time please Cc linux-usb

> ---
>  function/f_midi.c |    2 +-
>  legacy/gmidi.c    |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> Index: linux/drivers/usb/gadget/function/f_midi.c
> ===================================================================
> --- linux.orig/drivers/usb/gadget/function/f_midi.c
> +++ linux/drivers/usb/gadget/function/f_midi.c
> @@ -1069,7 +1069,7 @@ static void f_midi_unbind(struct usb_con
>  	usb_free_all_descriptors(f);
>  }
>  
> -struct usb_function *f_midi_alloc(struct usb_function_instance *fi)
> +static struct usb_function *f_midi_alloc(struct usb_function_instance *fi)
>  {
>  	struct f_midi *midi;
>  	struct f_midi_opts *opts;
> Index: linux/drivers/usb/gadget/legacy/gmidi.c
> ===================================================================
> --- linux.orig/drivers/usb/gadget/legacy/gmidi.c
> +++ linux/drivers/usb/gadget/legacy/gmidi.c
> @@ -115,8 +115,8 @@ static struct usb_gadget_strings *dev_st
>  	NULL,
>  };
>  
> -struct usb_function_instance *fi_midi;
> -struct usb_function *f_midi;
> +static struct usb_function_instance *fi_midi;
> +static struct usb_function *f_midi;
>  
>  static int __exit midi_unbind(struct usb_composite_dev *dev)
>  {

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)