linux-kernel - usb: gadget: midi: f_midi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 12 Nov 2014 21:28:24 +0800
From:	Fengguang Wu <fengguang.wu@...el.com>
To:	Felipe Balbi <balbi@...com>
Cc:	Andrzej Pietrasiewicz <andrzej.p@...sung.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: usb: gadget: midi: f_midi_alloc() can be static

drivers/usb/gadget/function/f_midi.c:1072:21: sparse: symbol 'f_midi_alloc' was not declared. Should it be static?
drivers/usb/gadget/legacy/gmidi.c:118:30: sparse: symbol 'fi_midi' was not declared. Should it be static?
drivers/usb/gadget/legacy/gmidi.c:119:21: sparse: symbol 'f_midi' was not declared. Should it be static?

Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
---
 function/f_midi.c |    2 +-
 legacy/gmidi.c    |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Index: linux/drivers/usb/gadget/function/f_midi.c
===================================================================
--- linux.orig/drivers/usb/gadget/function/f_midi.c
+++ linux/drivers/usb/gadget/function/f_midi.c
@@ -1069,7 +1069,7 @@ static void f_midi_unbind(struct usb_con
 	usb_free_all_descriptors(f);
 }
 
-struct usb_function *f_midi_alloc(struct usb_function_instance *fi)
+static struct usb_function *f_midi_alloc(struct usb_function_instance *fi)
 {
 	struct f_midi *midi;
 	struct f_midi_opts *opts;
Index: linux/drivers/usb/gadget/legacy/gmidi.c
===================================================================
--- linux.orig/drivers/usb/gadget/legacy/gmidi.c
+++ linux/drivers/usb/gadget/legacy/gmidi.c
@@ -115,8 +115,8 @@ static struct usb_gadget_strings *dev_st
 	NULL,
 };
 
-struct usb_function_instance *fi_midi;
-struct usb_function *f_midi;
+static struct usb_function_instance *fi_midi;
+static struct usb_function *f_midi;
 
 static int __exit midi_unbind(struct usb_composite_dev *dev)
 {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/