linux-kernel - Re: [PATCH] fuse: don't check for file->private

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0198135B-B7F1-4E40-A9E2-C9D56C421B6F@posteo.de>
Date:	Thu, 13 Nov 2014 12:13:32 +0100
From:	Martin Kepplinger <martink@...teo.de>
To:	Miklos Szeredi <miklos@...redi.hu>
CC:	fuse-devel <fuse-devel@...ts.sourceforge.net>,
	thierry.reding@...il.com,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	giedriuswork@...il.com,
	Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fuse: don't check for file->private_data on open().

Am 13. November 2014 11:53:29 MEZ, schrieb Miklos Szeredi <miklos@...redi.hu>:
>On Thu, Nov 13, 2014 at 11:05 AM, Martin Kepplinger <martink@...teo.de>
>wrote:
>
>> In this week's -next this should have changed. My SSD broke down so i
>have to delay further work for a few days, i'm sorry.
>
>Please be more careful with such patches.  Have you audited all of the
>(ca. 200) misc drivers?  If not, this might be a good time to do so.
>If it turns out to be too much, then consider not doing the change.
>The gain might not be worth the cost.
>
>NACK in this form.
>
>Thanks,
>Miklos

Definitely should have been more careful as I checked fs too late now. I totally unnecessarily broke -next.

But If fuse-devel is ok with a fix like the one i sent (still has to get tested too) i believe we're covered. I still call for independent review though.
-- 
Martin Kepplinger
http://martinkepplinger.com
sent from mobile
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/