linux-kernel - Re: [PATCH] fuse: don't check for file->private

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141113153458.GB26905@kroah.com>
Date:	Thu, 13 Nov 2014 07:34:58 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Martin Kepplinger <martink@...teo.de>
Cc:	Miklos Szeredi <miklos@...redi.hu>,
	fuse-devel <fuse-devel@...ts.sourceforge.net>,
	thierry.reding@...il.com, giedriuswork@...il.com,
	Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fuse: don't check for file->private_data on open().

On Thu, Nov 13, 2014 at 12:13:32PM +0100, Martin Kepplinger wrote:
> Am 13. November 2014 11:53:29 MEZ, schrieb Miklos Szeredi <miklos@...redi.hu>:
> >On Thu, Nov 13, 2014 at 11:05 AM, Martin Kepplinger <martink@...teo.de>
> >wrote:
> >
> >> In this week's -next this should have changed. My SSD broke down so i
> >have to delay further work for a few days, i'm sorry.
> >
> >Please be more careful with such patches.  Have you audited all of the
> >(ca. 200) misc drivers?  If not, this might be a good time to do so.
> >If it turns out to be too much, then consider not doing the change.
> >The gain might not be worth the cost.
> >
> >NACK in this form.
> >
> >Thanks,
> >Miklos
> 
> Definitely should have been more careful as I checked fs too late now. I totally unnecessarily broke -next.
> 
> But If fuse-devel is ok with a fix like the one i sent (still has to get tested too) i believe we're covered. I still call for independent review though.

I don't think it's worth it anymore, I'm going to revert the original
patch that caused these problems, as it has the potential to break other
drivers in ways that are not obvious (i.e. not at build time.)

Sorry,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/