linux-kernel - Re: [PATCH v2 1/3] trace: Replace seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141113213158.12fcca7d@gandalf.local.home>
Date:	Thu, 13 Nov 2014 21:31:58 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
	Joe Perches <joe@...ches.com>
Subject: Re: [PATCH v2 1/3] trace: Replace seq_printf by simpler equivalents

On Sat,  8 Nov 2014 21:42:10 +0100
Rasmus Villemoes <linux@...musvillemoes.dk> wrote:


> -	seq_printf(m, "\n");
> +	seq_puts(m, "\n");




>  
> @@ -840,7 +840,7 @@ static int probes_seq_show(struct seq_file *m, void *v)
>  
>  	for (i = 0; i < tk->tp.nr_args; i++)
>  		seq_printf(m, " %s=%s", tk->tp.args[i].name, tk->tp.args[i].comm);
> -	seq_printf(m, "\n");
> +	seq_puts(m, "\n");
>  
>  	return 0;
>  }
> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> index 33ff6a2..184aec1 100644
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -606,7 +606,7 @@ static int probes_seq_show(struct seq_file *m, void *v)
>  	for (i = 0; i < tu->tp.nr_args; i++)
>  		seq_printf(m, " %s=%s", tu->tp.args[i].name, tu->tp.args[i].comm);
>  
> -	seq_printf(m, "\n");
> +	seq_puts(m, "\n");

These can actually be seq_putc(m, '\n');

I saw this because one of them conflicted with a change I already had.

No need to resend, I'll just update them myself. Trivial enough.

-- Steve

>  	return 0;
>  }
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/