linux-kernel - Re: [PATCH v2 3/3] trace: Replace single-character seq_puts with seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141113213436.347351cb@gandalf.local.home>
Date:	Thu, 13 Nov 2014 21:34:36 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
	Joe Perches <joe@...ches.com>
Subject: Re: [PATCH v2 3/3] trace: Replace single-character seq_puts with
 seq_putc

On Sat,  8 Nov 2014 21:42:12 +0100
Rasmus Villemoes <linux@...musvillemoes.dk> wrote:

> Printing a single character to a seqfile might as well be done with
> seq_putc instead of seq_puts; this avoids a strlen() call and a memory
> access. It also shaves another few bytes off the generated code.
> 
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
> ---
>  kernel/trace/ftrace.c                |  2 +-
>  kernel/trace/trace_events_trigger.c  |  4 ++--
>  kernel/trace/trace_functions_graph.c |  4 ++--
>  kernel/trace/trace_kprobe.c          | 10 +++++-----
>  kernel/trace/trace_printk.c          |  2 +-
>  kernel/trace/trace_uprobe.c          |  4 ++--
>  6 files changed, 13 insertions(+), 13 deletions(-)
> 
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index 7890718..9ffd006 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -2969,7 +2969,7 @@ static int t_show(struct seq_file *m, void *v)
>  		}
>  	}	
>  
> -	seq_puts(m, "\n");
> +	seq_putc(m, '\n');

Ah, you did it here. Well, it is fine to have it in the first patch
anyway.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/