lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 14 Nov 2014 11:13:35 +0000
From:	Zubair Lutfullah Kakakhel <Zubair.Kakakhel@...tec.com>
To:	Andy Yan <andy.yan@...k-chips.com>, <airlied@...ux.ie>,
	<heiko@...ech.de>, <fabio.estevam@...escale.com>,
	<rmk+kernel@....linux.org.uk>
CC:	Mark Rutland <mark.rutland@....com>,
	<dri-devel@...ts.freedesktop.org>, <ykk@...k-chips.com>,
	<devel@...verdev.osuosl.org>, Arnd Bergmann <arnd@...db.de>,
	<linux-rockchip@...ts.infradead.org>,
	Grant Likely <grant.likely@...aro.org>,
	Dave Airlie <airlied@...hat.com>, <jay.xu@...k-chips.com>,
	<devicetree@...r.kernel.org>, Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Inki Dae <inki.dae@...sung.com>,
	Rob Herring <robh+dt@...nel.org>,
	Sean Paul <seanpaul@...omium.org>, <mark.yao@...k-chips.com>,
	Josh Boyer <jwboyer@...hat.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-kernel@...r.kernel.org>, <djkurtz@...gle.com>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Kumar Gala <galak@...eaurora.org>,
	Shawn Guo <shawn.guo@...aro.org>,
	Lucas Stach <l.stach@...gutronix.de>
Subject: Re: [PATCH v10 05/11] drm: bridge/dw_hdmi:split some phy configuration
 to platform driver



On 14/11/14 11:08, Andy Yan wrote:
> 
> On 2014年11月14日 18:55, Zubair Lutfullah Kakakhel wrote:
>>
>> On 14/11/14 10:53, Andy Yan wrote:
>>> Hi ZubairLK:
>>>     Thanks for your review.
>>> On 2014年11月14日 18:19, Zubair Lutfullah Kakakhel wrote:
>>>> Hi Andy,
>>>>
>>>> Nice work on this patch series. Its getting better and better :).
>>>>
>>>> On 14/11/14 03:27, Andy Yan wrote:
>>>>> hdmi phy clock symbol and transmission termination value
>>>>> can adjust platform specific to get the best SI
>>>>                          ^Is this signal integrity?
>>>     yes , SI  is signal integrity, such as eye diagram measurement
>>>> Are these two disjoint features in separate patches?
>>>>
>>>>> also add mode_valid interface for some platform may not support
>>>>> all the display mode
>>>> Sounds like another separate patch to me. :)
>>>     they can seperate
>>>> Also, This series is becoming quite large. With major changes and fixes mixed together.
>>>>
>>>> Patch 3 splits imx-drm.
>>>> Patch 4 moves dw-drm out of imx-drm folder.
>>>> Patch 7 adds binding
>>>> Patch 9 converts to drm bridge.
>>>>
>>>> Can these be placed together easily?
>>>> And in the start. i.e. patch 1, 2, 3, 4,
>>>>
>>>> Then all fixes etc can come afterwards?
>>>>
>>>> It helps when checking histories later as to how a driver was made and how fixes happened.
>>>>
>>>> Especially when file moves happen..
>>>    Do you mean we can rearrange the patch series?
>>>    put patch 3, 4 ,7, 9 together  one bye one
>>>    than followed by the fixes patches  5 ,6, 8, 11 ?
>> Yes. Rearrange so that the split imx-drm/imx-hdmi and conversion to drm-bridge is at the start of the series.
>> Then the rest are bug fixes and feature additions.
>   Can I put patch#1(make checkpatch happy) and patch#2 (defer probe) as the first two patch.
>   Daniel from Google chromium think it's better to put the two slightly changes in the front for easy review.

Sure.

I am not the maintainer. They have to make the final decision.

ZubairLK
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists