linux-kernel - Re: [RFC][PATCH 06/23 v4] tracing: Have function_graph use trace_seq_has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141114075209.5a358890@gandalf.local.home>
Date:	Fri, 14 Nov 2014 07:52:09 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Petr Mladek <pmladek@...e.cz>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jiri Kosina <jkosina@...e.cz>
Subject: Re: [RFC][PATCH 06/23 v4] tracing: Have function_graph use
 trace_seq_has_overflowed()

On Fri, 14 Nov 2014 13:41:26 +0100
Petr Mladek <pmladek@...e.cz> wrote:

  
> > -static enum print_line_t
> > +static void
> >  print_graph_irq(struct trace_iterator *iter, unsigned long addr,
> >  		enum trace_type type, int cpu, pid_t pid, u32 flags)
> >  {
> > -	int ret;
> >  	struct trace_seq *s = &iter->seq;
> >  
> >  	if (addr < (unsigned long)__irqentry_text_start ||
> >  		addr >= (unsigned long)__irqentry_text_end)
> > -		return TRACE_TYPE_UNHANDLED;
> > +		return;
> 
> I was curious if the TRACE_TYPE_UNHANDLED return value has any special
> effect. But it seems to be ignored. There are only two callers and
> they take care only of the PARTIAL_LINE return value.

Yep, I noticed that too, and did the same check before I made the
change. IIRC, that UNHANDLED was written in case anyone did care.

> 
> [...]
> 
> > @@ -953,62 +856,43 @@ print_graph_entry_nested(struct trace_iterator *iter,
> >  	return TRACE_TYPE_NO_CONSUME;
> >  }
> >  
> > -static enum print_line_t
> > +static void
> >  print_graph_prologue(struct trace_iterator *iter, struct trace_seq *s,
> >  		     int type, unsigned long addr, u32 flags)
> >  {
> >  	struct fgraph_data *data = iter->private;
> >  	struct trace_entry *ent = iter->ent;
> >  	int cpu = iter->cpu;
> > -	int ret;
> >  
> >  	/* Pid */
> > -	if (verif_pid(s, ent->pid, cpu, data) == TRACE_TYPE_PARTIAL_LINE)
> > -		return TRACE_TYPE_PARTIAL_LINE;
> > +	verif_pid(s, ent->pid, cpu, data);
> >  
> > -	if (type) {
> > +	if (type)
> >  		/* Interrupt */
> > -		ret = print_graph_irq(iter, addr, type, cpu, ent->pid, flags);
> > -		if (ret == TRACE_TYPE_PARTIAL_LINE)
> > -			return TRACE_TYPE_PARTIAL_LINE;
> > -	}
> > +		print_graph_irq(iter, addr, type, cpu, ent->pid, flags);
> >  
> >  	if (!(trace_flags & TRACE_ITER_CONTEXT_INFO))
> > -		return 0;
> > +		return;
> >  
> >  	/* Absolute time */
> > -	if (flags & TRACE_GRAPH_PRINT_ABS_TIME) {
> > -		ret = print_graph_abs_time(iter->ts, s);
> > -		if (!ret)
> > -			return TRACE_TYPE_PARTIAL_LINE;
> > -	}
> > +	if (flags & TRACE_GRAPH_PRINT_ABS_TIME)
> > +		print_graph_abs_time(iter->ts, s);
> >  
> >  	/* Cpu */
> > -	if (flags & TRACE_GRAPH_PRINT_CPU) {
> > -		ret = print_graph_cpu(s, cpu);
> > -		if (ret == TRACE_TYPE_PARTIAL_LINE)
> > -			return TRACE_TYPE_PARTIAL_LINE;
> > -	}
> > +	if (flags & TRACE_GRAPH_PRINT_CPU)
> > +		print_graph_cpu(s, cpu);
> >  
> >  	/* Proc */
> >  	if (flags & TRACE_GRAPH_PRINT_PROC) {
> > -		ret = print_graph_proc(s, ent->pid);
> > -		if (ret == TRACE_TYPE_PARTIAL_LINE)
> > -			return TRACE_TYPE_PARTIAL_LINE;
> > -
> > -		ret = trace_seq_puts(s, " | ");
> > -		if (!ret)
> > -			return TRACE_TYPE_PARTIAL_LINE;
> > +		print_graph_proc(s, ent->pid);
> > +		trace_seq_puts(s, " | ");
> >  	}
> >  
> >  	/* Latency format */
> > -	if (trace_flags & TRACE_ITER_LATENCY_FMT) {
> > -		ret = print_graph_lat_fmt(s, ent);
> > -		if (ret == TRACE_TYPE_PARTIAL_LINE)
> > -			return TRACE_TYPE_PARTIAL_LINE;
> > -	}
> > +	if (trace_flags & TRACE_ITER_LATENCY_FMT)
> > +		print_graph_lat_fmt(s, ent);
> >  
> > -	return 0;
> > +	return;
> 
> This probably even fixed a bug. The function returned
> TRACE_TYPE_PARTIAL_LINE (0) even when it did not print anything.
> 
> The simplification is really cool.

Thanks,

-- Steve

> 
> Reviewed-by: Petr Mladek <pmladek@...e.cz>
> 
> Best Regards,
> Petr Mladek

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/