linux-kernel - Re: [PATCH] mm: mincore: add hwpoison page handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141114010320.GA15456@hori1.linux.bs1.fc.nec.co.jp>
Date:	Fri, 14 Nov 2014 01:02:44 +0000
From:	Naoya Horiguchi <n-horiguchi@...jp.nec.com>
To:	Johannes Weiner <hannes@...xchg.org>
CC:	Weijie Yang <weijie.yang@...sung.com>,
	"'Andrew Morton'" <akpm@...ux-foundation.org>,
	"mgorman@...e.de" <mgorman@...e.de>,
	"'Rik van Riel'" <riel@...hat.com>,
	"'Weijie Yang'" <weijie.yang.kh@...il.com>,
	"'Linux-MM'" <linux-mm@...ck.org>,
	"'linux-kernel'" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: mincore: add hwpoison page handle

On Wed, Nov 12, 2014 at 09:20:22AM -0500, Johannes Weiner wrote:
> On Wed, Nov 12, 2014 at 11:39:29AM +0800, Weijie Yang wrote:
> > When encounter pte is a swap entry, the current code handles two cases:
> > migration and normal swapentry, but we have a third case: hwpoison page.
> > 
> > This patch adds hwpoison page handle, consider hwpoison page incore as
> > same as migration.
> > 
> > Signed-off-by: Weijie Yang <weijie.yang@...sung.com>

Acked-by: Naoya Horiguchi <n-horiguchi@...jp.nec.com>

> 
> The change makes sense:
> 
> Acked-by: Johannes Weiner <hannes@...xchg.org>
> 
> But please add a description of what happens when a poison entry is
> encountered with the current code.  I'm guessing swap_address_space()
> will return garbage and this might crash the kernel?

Yes, I think that's correct.

Thanks,
Naoya Horiguchi--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/