linux-kernel - Re: [PATCH] mm: mincore: add hwpoison page handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141112142022.GA29766@phnom.home.cmpxchg.org>
Date:	Wed, 12 Nov 2014 09:20:22 -0500
From:	Johannes Weiner <hannes@...xchg.org>
To:	Weijie Yang <weijie.yang@...sung.com>
Cc:	'Andrew Morton' <akpm@...ux-foundation.org>, mgorman@...e.de,
	'Rik van Riel' <riel@...hat.com>,
	'Weijie Yang' <weijie.yang.kh@...il.com>,
	'Linux-MM' <linux-mm@...ck.org>,
	'linux-kernel' <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: mincore: add hwpoison page handle

On Wed, Nov 12, 2014 at 11:39:29AM +0800, Weijie Yang wrote:
> When encounter pte is a swap entry, the current code handles two cases:
> migration and normal swapentry, but we have a third case: hwpoison page.
> 
> This patch adds hwpoison page handle, consider hwpoison page incore as
> same as migration.
> 
> Signed-off-by: Weijie Yang <weijie.yang@...sung.com>

The change makes sense:

Acked-by: Johannes Weiner <hannes@...xchg.org>

But please add a description of what happens when a poison entry is
encountered with the current code.  I'm guessing swap_address_space()
will return garbage and this might crash the kernel?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/