linux-kernel - Re: [PATCH] staging: media: bcm2048: fix coding style error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 16 Nov 2014 08:20:23 -0200
From:	Mauro Carvalho Chehab <mchehab@....samsung.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	Pavel Machek <pavel@....cz>,
	Konrad Zapalowicz <bergo.torino@...il.com>,
	Christian Resell <christian.resell@...il.com>,
	devel@...verdev.osuosl.org, askb23@...il.com,
	linux-kernel@...r.kernel.org, yongjun_wei@...ndmicro.com.cn,
	hans.verkuil@...co.com, pali.rohar@...il.com,
	fengguang.wu@...el.com, linux-media@...r.kernel.org
Subject: Re: [PATCH] staging: media: bcm2048: fix coding style error

Em Sat, 15 Nov 2014 13:25:03 -0800
Greg KH <gregkh@...uxfoundation.org> escreveu:

> On Sat, Nov 15, 2014 at 09:59:34PM +0100, Pavel Machek wrote:
> > On Sat 2014-11-15 21:12:18, Konrad Zapalowicz wrote:
> > > On 11/15, Christian Resell wrote:
> > > > Simple style fix (checkpatch.pl: "space prohibited before that ','").
> > > > For the eudyptula challenge (http://eudyptula-challenge.org/).
> > > 
> > > Nice, however we do not need the information about the 'eudyptula
> > > challenge' in the commit message.
> > > 
> > > If you want to include extra information please do it after the '---'
> > > line (just below the signed-off). You will find more details in the
> > > SubmittingPatches (chapter 15) of the kernel documentation.
> > 
> > Greg is staging tree maintainer... And if single extra space is all
> > you can fix in the driver, perhaps it is not worth the patch?
> 
> I am not the maintainer of drivers/staging/media/ please look at
> MAINTAINERS before you make statements like that.
> 
> And yes, one space fixes is just fine, that's why the code is in
> staging.

Yes, space fixes is OK for staging.

I'll apply this patch, removing the line that comments about the challenge,
as we don't need to keep this information forever at the Kernel history.

Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/