linux-kernel - Re: [PATCH v3] usb: dwc2: add bus suspend/resume for dwc2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <546A0554.1080809@rock-chips.com>
Date:	Mon, 17 Nov 2014 22:25:24 +0800
From:	Kever Yang <kever.yang@...k-chips.com>
To:	Alan Stern <stern@...land.harvard.edu>,
	Julius Werner <jwerner@...omium.org>
CC:	Doug Anderson <dianders@...omium.org>,
	Paul Zimmerman <paulz@...opsys.com>,
	Felipe Balbi <balbi@...com>,
	Dinh Nguyen <dinguyen@...nsource.altera.com>,
	Romain Perier <romain.perier@...il.com>,
	Heiko Stuebner <heiko@...ech.de>,
	Sonny Rao <sonnyrao@...omium.org>,
	Addy Ke <addy.ke@...k-chips.com>,
	Eddie Cai <cf@...k-chips.com>, lyz <lyz@...k-chips.com>,
	wulf <wulf@...k-chips.com>, Tao Huang <huangtao@...k-chips.com>,
	"open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] usb: dwc2: add bus suspend/resume for dwc2


On 11/14/2014 11:55 PM, Alan Stern wrote:
> On Thu, 13 Nov 2014, Julius Werner wrote:
>
>> Another thing might be that the port connect interrupt does not
>> correctly resume the root hub. I don't really know many details about
>> how that works, and it seems pretty complicated. But I can see that
>> all other HCDs seem to call usb_hcd_resume_root_hub() from their
>> interrupt handlers, which we don't. There's also a
> That's how a root hub sends a wakeup request to the kernel.  The
> controller issues an interrupt, and when the HCD's interrupt handler
> sees that the root hub is suspended, it calls usb_hcd_resume_root_hub()
> instead of trying to query the hardware (because in general you _can't_
> query the hardware while it's in a low-power state).
Thanks Alan and Julius, just like what you have mentioned, the dwc2 miss the
usb_hcd_resume_root_hub() when root hub is suspended and device connect
detected.

I have send another patch for that, hope it did the right thing.

- Kever

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/