linux-kernel - Re: [PATCH] i2c: core: Fix probing of i2c slaves without interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141117181214.GB12644@katana>
Date:	Mon, 17 Nov 2014 19:12:14 +0100
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Fabio Estevam <festevam@...il.com>
Cc:	Geert Uytterhoeven <geert+renesas@...der.be>,
	Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
	linux-i2c <linux-i2c@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-sh@...r.kernel.org
Subject: Re: [PATCH] i2c: core: Fix probing of i2c slaves without interrupts

On Mon, Nov 17, 2014 at 03:08:25PM -0200, Fabio Estevam wrote:
> On Mon, Nov 17, 2014 at 9:43 AM, Geert Uytterhoeven
> <geert+renesas@...der.be> wrote:
> > Since commit 2fd36c55264926e2 ("i2c: core: Map OF IRQ at probe time"),
> > i2c slaves without interrupts (e.g. da9210 and at24 on r8a7791/koelsch)
> > fail to probe:
> >
> >     at24: probe of 2-0050 failed with error -22
> >
> >     da9210: probe of 6-0068 failed with error -22
> >
> > This happens because the call to of_irq_get() in i2c_device_probe()
> > returns -EINVAL.
> >
> > If a device node does not have an "interrupts" property,
> > of_irq_parse_one() fails. Unlike irq_of_parse_and_map(), of_irq_get()
> > does not ignore errors from of_irq_parse_one(), but forwards them.
> >
> > Make i2c_device_probe() ignore all errors but -EPROBE_DEFER to fix this,
> > just like platform_get_irq() and platform_get_irq_byname() already do.
> >
> > Fixes: 2fd36c55264926e2 ("i2c: core: Map OF IRQ at probe time")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> 
> With this patch applied my codec and PMIC can be probed again:
> 
> Tested-by: Fabio Estevam <fabio.estevam@...escale.com>

Applied to for-next, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)