linux-kernel - Re: [PATCH] usb: dwc2: resume root hub when device detect with suspend state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 17 Nov 2014 21:16:51 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Kever Yang <kever.yang@...k-chips.com>,
	Paul Zimmerman <paulz@...opsys.com>,
	Felipe Balbi <balbi@...com>
CC:	Dinh Nguyen <dinguyen@...nsource.altera.com>,
	romain.perier@...il.com, Heiko Stuebner <heiko@...ech.de>,
	dianders@...omium.org, sonnyrao@...omium.org,
	addy.ke@...k-chips.com, cf@...k-chips.com, wulf@...k-chips.com,
	huangtao@...k-chips.com, linux-rockchip@...ts.infradead.org,
	Roy Li <roy.li@...k-chips.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: dwc2: resume root hub when device detect with suspend
 state

Hello.

On 11/17/2014 04:14 PM, Kever Yang wrote:

> After we implement the bus_suspend/resume, auto suspend id enabled.
> The root hub will be auto suspend if there is no device connected,
> we need to resume the root hub when a device connect detect.

> This patch tested on rk3288.

> Signed-off-by: Roy Li <roy.li@...k-chips.com>
> Signed-off-by: Kever Yang <kever.yang@...k-chips.com>
> ---

>   drivers/usb/dwc2/hcd_intr.c | 7 +++++++
>   1 file changed, 7 insertions(+)

> diff --git a/drivers/usb/dwc2/hcd_intr.c b/drivers/usb/dwc2/hcd_intr.c
> index 551ba87..c8299fd 100644
> --- a/drivers/usb/dwc2/hcd_intr.c
> +++ b/drivers/usb/dwc2/hcd_intr.c
> @@ -355,6 +355,13 @@ static void dwc2_port_intr(struct dwc2_hsotg *hsotg)
>   		hprt0_modify |= HPRT0_CONNDET;
>
>   		/*
> +		 * Check if root hub is in suspend state
> +		 * if root hub in suspend, resume it.
> +		 */
> +		if ((bus->root_hub) && (hcd->state == HC_STATE_SUSPENDED))

    Inner parens are not needed, especially the first ones.

[...]

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/